Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[skip-changelog] Some integration test refactorings #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 8 commits into arduino:master from cmaglie:refactor_testsuite
Oct 10, 2022

Conversation

Copy link
Member

@cmaglie cmaglie commented Oct 7, 2022

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

  • The library go.bug.st/testsuite has been integrated into the repo: it doesn't make much sense to have it separated in a different library. We may possibly extract the most useful function in the future if we deem it useful.
  • Added a SharedDir object to share directories between tests. The shared directory is locked before use and must be unlocked after use. The SharedDir object provides Lock and Unlock methods to do so.
  • Refined some minor stuff.

What is the current behavior?

No changes in behavior

What is the new behavior?

No changes in behavior

Does this PR introduce a breaking change, and is titled accordingly?

No

@cmaglie cmaglie added type: enhancement Proposed improvement priority: low Resolution is a low priority topic: infrastructure Related to project infrastructure criticality: low Of low impact labels Oct 7, 2022
@cmaglie cmaglie self-assigned this Oct 7, 2022
Copy link

codecov bot commented Oct 7, 2022 •
edited
Loading

Codecov Report

Base: 36.65% // Head: 36.84% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (1cb8d07) compared to base (2480d93).
Patch coverage: 95.18% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #1911 +/- ##
==========================================
+ Coverage 36.65% 36.84% +0.18% 
==========================================
 Files 231 234 +3 
 Lines 19683 19758 +75 
==========================================
+ Hits 7215 7280 +65 
- Misses 11640 11648 +8 
- Partials 828 830 +2
Flag Coverage Δ
unit 36.84% <95.18%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/integrationtest/shared_directory.go 82.60% <82.60%> (ø)
internal/integrationtest/arduino-cli.go 85.91% <100.00%> (+0.25%) ⬆️
internal/integrationtest/environment.go 100.00% <100.00%> (ø)
internal/integrationtest/http_server.go 100.00% <100.00%> (ø)
arduino/monitor/monitor.go 41.05% <0.00%> (-4.74%) ⬇️
arduino/cores/packagemanager/package_manager.go 66.58% <0.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos umbynos changed the title (削除) Some integration test refactorings (削除ここまで) (追記) [skip-changelog] Some integration test refactorings (追記ここまで) Oct 10, 2022 
Co-authored-by: MatteoPologruto <109663225+MatteoPologruto@users.noreply.github.com>
@cmaglie cmaglie merged commit 063f4f8 into arduino:master Oct 10, 2022
@cmaglie cmaglie deleted the refactor_testsuite branch October 10, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

@per1234 per1234 Awaiting requested review from per1234

+1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
criticality: low Of low impact priority: low Resolution is a low priority topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /