-
-
Notifications
You must be signed in to change notification settings - Fork 422
Do not treat custom menu options without label as 'malformed' #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 36.68% // Head: 36.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@ ## master #1882 +/- ## ========================================== - Coverage 36.68% 36.58% -0.11% ========================================== Files 231 231 Lines 19680 19677 -3 ========================================== - Hits 7219 7198 -21 - Misses 11633 11648 +15 - Partials 828 831 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8b74195
to
ec5bbd5
Compare
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)Do not report the board menu without a label as an error. It happens when the
boards.txt
does not specify a top-levelmenu.xxx
directive, for example:If the menu directive is missing the CLI fails to load the whole platform with the message:
The CLI will silently accept the board option without the label.
Not exactly a breaking change, but worth noting that the gRPC response to
BoardDetails
now may have aConfigOption
with a blankoption_label
field: