-
-
Notifications
You must be signed in to change notification settings - Fork 422
[breaking] Fix behaviour of lib commands when a library is installed multiple times
#1878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 36.68% // Head: 36.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@ ## master #1878 +/- ## ========================================== - Coverage 36.68% 36.62% -0.06% ========================================== Files 231 231 Lines 19680 19708 +28 ========================================== - Hits 7219 7218 -1 - Misses 11633 11662 +29 Partials 828 828
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It does not require installLocation since it can be obtained with libPath.Parent()
4b5c636 to
1908634
Compare
a540762 to
078fd9f
Compare
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
Name->CanonicalNameRealName->Name
This change is quite involved in the go-lang codebase but results in a backward compatible change in the user-facing API.
Would you consider applying the same change on the gRPC API?
IDE2 still uses both. RealName is available on the UI, and Name is the unique ID of the lib.
Should IDE2 apply any changes after closing #932?
Thank you!
Now both Name and RealName gets the same value: the library unique name (as written in the index / library.properties).
I forget to change the description on the field Name, will do it in a new PR.
I kept RealName for backward compatibility, so there should be no changes required in the IDE.
BTW it's probably better to remove the RealName field and cleanup the API, WDYT?
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fix bugs reported in:
namevsreal_nameinconsistency when executing lib commands #932lib installandlib upgrademay cause multiple installations of the same librarylib install/upgrade/uninstallon a library installed multiple times, the command may act only on one of the multiple copies (chosen pseudo-randomly).lib example "Robot_Control"instead oflib example "Robot Control".lib installandlib upgradewill not cause multiple installations anymorelib install/upgrade/uninstallon a library installed multiple times, the command will fail, showing the path of every copy of the library and asking to manually fix the multiple installations.library.propertiesfile)Yes. The biggest change is the renaming of the fields in the
Librarystructure:Name->CanonicalNameRealName->NameThis change is quite involved in the go-lang codebase but results in a backward compatible change in the user-facing API. It should make the overall API usage more straightforward since it factors out the legacy (IDE <1.5) way to name the libraries as the containing directory.