-
-
Notifications
You must be signed in to change notification settings - Fork 422
Added Type field to Platform gRPC struct #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Related to arduino/arduino-ide#177
3a7e58d to
61e3e01
Compare
Codecov Report
@@ Coverage Diff @@ ## master #1853 +/- ## ======================================= Coverage 36.37% 36.38% ======================================= Files 231 231 Lines 19572 19573 +1 ======================================= + Hits 7120 7121 +1 Misses 11622 11622 Partials 830 830
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This does not seem to be correct:
./arduino-cli lib search "ArduinoOTA" --format json:
Part of the output JSON:
"latest": { "author": "Arduino,Juraj Andrassy", "version": "1.0.8", "maintainer": "Juraj Andrassy \u003cjuraj.andrassy@gmail.com\u003e", "sentence": "Upload sketch over network to Arduino board with WiFi or Ethernet libraries", "paragraph": "Based on WiFi101OTA library. Uploads over Ethernet, EthernetENC, WiFi101, WiFiNina, WiFiEspAT to SAMD, nRF5, RP2040, STM32F1, ESP and to classic ATmega with more than 64 kB flash memory.", "website": "https://github.com/jandrassy/ArduinoOTA", "category": "Other", "architectures": [ "*" ], "types": [ "Contributed" ], "resources": { "url": "https://downloads.arduino.cc/libraries/github.com/jandrassy/ArduinoOTA-1.0.8.zip", "archive_filename": "ArduinoOTA-1.0.8.zip", "checksum": "SHA-256:d36504623df593ea79db03ec6eb2601c45055ba0583414fced02b1c16ff7a779", "size": 82017, "cache_path": "libraries" }, "provides_includes": [ "ArduinoOTA.h" ] }
types (which is available only from LibraryRelease) should be an array of these values:
Screen Shot 2022年08月29日 at 13 38 27
And the category should be one of these:
Screen Shot 2022年08月29日 at 13 38 50
For the platforms, type is not present, and category is:
Screen Shot 2022年08月29日 at 13 39 46
This is not working correctly; see JSON above.
@kittaakos
I've renamed category field to type so the meaning matches on both platform and libraries. Also the type has been changed from string to []string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the functionality from arduino/arduino-ide#1361. The Type and Topic filters work as in IDE (1.x).
Thank you for the support!
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Add
categoryfield toPlatformgRPC structNo