* Improved streaming of pluggable-discoveries events (WIP)
Now the DiscoveryManager is able to start the discoveries and add/remove
them in a thread-safe way. Also the watchers may connect and disconnect
seamlessly at any time, the incoming events from the discovery are
broadcasted correctly to each active watcher.
This refactoring dramatically simplifies the DiscoveryManager design.
* Added discovery id in discovery.Event struct
* Cache active ports and transmit them when a new watcher connects
* Correctly handle discovery cleanup
* Fixed wrong test
* Correctly handle discovery cleanup and re-add
* Added some doc comments in the source code
* Move Unlock under defer
* Factored subrotuine into a function
it will be useful in the next commits.
* Do not cache ports in the DiscoveryClient
there is already a cache in the DiscoveryManager there is no need to
duplicate it.
* Discovery: eventChan must be protected by mutex when doing START_SYNC
otherwise the discovery may send some events before the eventChan is
setup (and those events will be lost)
* Increased error level for logging watchers that lags
* Updated discvoery_client to the latest API
* Report discovery start errors
* Update arduino/discovery/discovery_client/main.go
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>

...nager (#1828)
* legacy: Removed ToolsLoader step
It has been splitted and merged into HardwareLoader and TargetBoardResolver
that are more appropriate.
* Fixed some function comments
* Thread-safe protect access to instances map
* Removed state-altering methods from PackageManager
They have been moved into a Builder object that has the ability to build
a new PackageManager. This allows to clearly separate subrotuines that
actually change the status of the PackageManager from subroutines that
just need to query it.
* Created packagemanager.Explorer to query PackageManager data
The Explorer object can be see as a read-only "view" to the underlying
PackageManager: we may ask the PackageManager to create an Explorer on
itself. The returned explorer will held a read-lock on the
PackageManager until it's disposed.
This architecture should prevent unwanted changes on the PackageManager
while it's being used, and viceversa, when the PackageManager is updated
it should be guaranteed that no Explorers are reading it.
* PlatformInstall/Uninstall must release PackageManager.Explorer before calling commands.Init
Otherwise, since Init will try to take a write-lock, it will block
indefinitely.
* Moved commands.InstanceContainer -> rpc.InstanceCommand
* Created a coreInstancesContainer
This container will handle all the atomic access to the instances map.
* Made CoreInstance.PackageManager field private
* Moved the reminder of PackageManager functions to Explorer or Builder
* Now GetPackageManager accepts an rpc.InstanceCommand
It has also been deprecated in favor of GetPackageManagerExplorer.
* Now GetLibraryManager accepts an rpc.InstanceCommand
* Refactored automatic builtin-tool installation
* Added gRPC LibraryUpgrade call and fixed 'lib upgrade' command
* Explorer and Builder should not extend PackageManager
Previuosly the methods PackageManager.NewBuilder and
PackageManager.NewExplorer were available also on Builder and Explorer.
Now Builder and Explorer does not inherith these methods anymore,
avoiding trivial errors like the one fixed in this commit in the
builder_utils package.
* Updated documentation
* Apply suggestions from code review
Co-authored-by: per1234 <accounts@perglass.com>

@kittaakos kittaakos left a comment