-
-
Notifications
You must be signed in to change notification settings - Fork 423
[skip-changelog] Migrate tests from test_completion.py to completion_test.go
#1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #1844 +/- ## ========================================== + Coverage 36.37% 36.39% +0.01% ========================================== Files 231 231 Lines 19572 19572 ========================================== + Hits 7120 7123 +3 + Misses 11622 11620 -2 + Partials 830 829 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
2beac6c to
a5d1de4
Compare
test_completion.py to completion_test.go (削除ここまで)test_completion.py to completion_test.go (追記ここまで)
a5d1de4 to
9c4422b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
The hide=True is not a problem. It was used only to hide some output from the terminal when the test is run.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the new behavior?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_completion.pyhave been rewritten incompletion_test.go, without changing their original purpose.The tests are the following:
I could not find a way to correctly implement the
hide=trueflag present in the first half of the commands of the original TestLibCompletion, so I omitted it while rewriting them. For example:result = run_command(["__complete", "lib", "install", ""], hide=True)has simply been rewritten as
stdout, _, _ := cli.Run("__complete", "lib", "install", "")If you have any suggestions, I will modify the corresponding commit.
Does this PR introduce a breaking change, and is
titled accordingly?
No
See how to contribute