Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[skip-changelog] Migrate tests from test_outdated.py to outdated_test.go #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatteoPologruto merged 2 commits into master from test-outdated-to-go
Sep 2, 2022

Conversation

Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Aug 17, 2022 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure enhancement

What is the new behavior?

This PR is a followup to PR #1806
Integration tests that were previously present in test_outdated.py have been rewritten in outdated_test.go, without changing their original purpose.
The tests are the following:

  • TestOutdated
  • TestOutdatedUsingLibraryWithInvalidVersion

Does this PR introduce a breaking change, and is titled accordingly?

No

See how to contribute

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Aug 17, 2022
Copy link

codecov bot commented Aug 17, 2022 •
edited
Loading

Codecov Report

Merging #1841 (ab61e0b) into master (25d9100) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head ab61e0b differs from pull request most recent head c32abdd. Consider uploading reports for the commit c32abdd to get more accurate results

@@ Coverage Diff @@
## master #1841 +/- ##
==========================================
+ Coverage 36.66% 36.71% +0.04% 
==========================================
 Files 231 232 +1 
 Lines 19609 20160 +551 
==========================================
+ Hits 7190 7401 +211 
- Misses 11594 11931 +337 
- Partials 825 828 +3
Flag Coverage Δ
unit 36.71% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
configuration/directories.go 75.00% <0.00%> (-7.76%) ⬇️
cli/core/search.go 0.00% <0.00%> (ø)
cli/daemon/daemon.go 0.00% <0.00%> (ø)
cli/config/validate.go 0.00% <0.00%> (ø)
commands/lib/install.go 0.00% <0.00%> (ø)
commands/lib/upgrade.go 0.00% <0.00%> (ø)
commands/daemon/debug.go 0.00% <0.00%> (ø)
commands/daemon/daemon.go 0.00% <0.00%> (ø)
commands/lib/uninstall.go 0.00% <0.00%> (ø)
commands/compile/compile.go 0.00% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie Awaiting requested review from cmaglie

1 more reviewer

@umbynos umbynos umbynos approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /