-
-
Notifications
You must be signed in to change notification settings - Fork 423
[skip-changelog] Migrate tests from test_debug.py to debug_test.go
#1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #1840 +/- ## ======================================= Coverage 36.38% 36.38% ======================================= Files 231 231 Lines 19573 19573 ======================================= Hits 7121 7121 Misses 11622 11622 Partials 830 830
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0209247 to
f5c68f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
f5c68f8 to
dcc408a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks!
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the new behavior?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_debug.pyhave been rewritten indebug_test.go, without changing their original purpose.The tests are the following:
Does this PR introduce a breaking change, and is titled accordingly?
No
See how to contribute