-
-
Notifications
You must be signed in to change notification settings - Fork 423
[skip-changelog] Migrate tests from test_main.py to main_test.go
#1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA assistant check
All committers have signed the CLA.
Codecov Report
@@ Coverage Diff @@ ## master #1836 +/- ## ========================================== - Coverage 36.34% 36.28% -0.07% ========================================== Files 232 232 Lines 19496 19496 ========================================== - Hits 7086 7074 -12 - Misses 11583 11592 +9 - Partials 827 830 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some small adjustments, but looks good overall 👍🏼
f41c63d to
d81f8f1
Compare
Thanks for the suggestion @cmaglie! Committed the changes and cleaned the commit history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
test_main.py to main_test.go (追記ここまで)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d81f8f1 to
8a86752
Compare
...rduino#1836) * Migrated TestHelp from test_main.py to main_test.go * Migrated TestVersion from test_main.py to main_test.go * Migrated TestInventoryCreation from test_main.py to main_test.go * Migrated TestLogOptions to main_test.go and deleted test_main.py
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_main.pyhave been rewritten inmain_test.go, without changing their original purpose.The tests are the following:
I had to introduce a way to skip blank lines while checking the content of the log file written with the command
version --log-format json --log-file path/log.jsonin TestLogOptions. It seems that VSCode does not handle well a stream of JSONs and expects the end of the file to be sooner than the actual file's end, leaving a blank line in place of the last line of the file as a result, potentially compromising the whole test.Does this PR introduce a breaking change, and is titled accordingly?
No