-
-
Notifications
You must be signed in to change notification settings - Fork 422
[breaking] Downloaders/Installers refactor #1809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] Downloaders/Installers refactor #1809
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #1809 +/- ## ========================================== + Coverage 35.50% 35.87% +0.37% ========================================== Files 230 231 +1 Lines 19532 19324 -208 ========================================== - Hits 6934 6933 -1 + Misses 11773 11567 -206 + Partials 825 824 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
65b3621 to
851dfc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent tidying up of the code happening here.
Thanks Cristian!
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Removes a TON of code-duplication. Makes a couple of fields in
PackageManagerprivate.Does this PR introduce a breaking change, and is titled accordingly?
Yes
Other information:
This PR is part of a bigger refactoring to solve concurrency problems in
PackageManager, it started by trying to make thePackageManagerfields private, but making theLogfield private started a massive chain reaction that lead to this PR.