-
-
Notifications
You must be signed in to change notification settings - Fork 422
disable CGO on every OS except macOS #1751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@umbynos
umbynos
added
type: enhancement
Proposed improvement
os: windows
Specific to Windows operating system
os: linux
Specific to Linux operating system
topic: packaging
Related to the release distribution package
labels
Jun 8, 2022
cmaglie
cmaglie
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)enhancement
The Arduino CLI is built with
CGO_ENABLED=1
:This does not allow the cli to be a fully static binary. We have to use CGO because of
go.bug.st/serial.v1/enumerator
used bygo.bug.st/serial
:CGO is disabled on every OS except macOS. This gives some advantages (for example on Linux amd64):
new
old
titled accordingly?
nop
See how to contribute