-
-
Notifications
You must be signed in to change notification settings - Fork 422
Allow downloading index and signature in a single tar.bz2 archive #1734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
umbynos
reviewed
May 18, 2022
umbynos
umbynos
reviewed
May 18, 2022
umbynos
umbynos
reviewed
May 18, 2022
umbynos
umbynos
reviewed
May 18, 2022
umbynos
umbynos
reviewed
May 18, 2022
umbynos
umbynos
reviewed
May 18, 2022
umbynos
umbynos
suggested changes
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions/suggestions
@cmaglie
cmaglie
force-pushed
the
signature_archive
branch
from
May 18, 2022 15:22
77ff5f4 to
1583929
Compare
umbynos
umbynos
approved these changes
May 19, 2022
Nice work 🥇
@cmaglie
cmaglie
force-pushed
the
signature_archive
branch
2 times, most recently
from
May 20, 2022 13:25
b1e25f3 to
e4b1ec0
Compare
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
@cmaglie
cmaglie
force-pushed
the
signature_archive
branch
from
May 20, 2022 15:00
1f1bcfd to
7d14f3c
Compare
umbynos
umbynos
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Allow downloading index and signature in a single tar.bz2 archive
Does this PR introduce a breaking change, and is titled accordingly?
No