Mar 22, 2022 · Mar 22, 2022 · Mar 22, 2022 · Mar 23, 2022 · Mar 24, 2022 · Mar 24, 2022
diff --git a/arduino/errors.go b/arduino/errors.go
diff --git a/commands/instances.go b/commands/instances.go
Original file line number	Diff line number	Diff line change
Expand Up		@@ -698,21 +698,22 @@ func (e TempDirCreationFailedError) ToRPCStatus() status.Status {
		return status.New(codes.Unavailable, e.Error())
		}

	// TempFileCreationFailedError is returned if a temp file could not be created
	type TempFileCreationFailedError struct {
	Cause error
	// FileCreationFailedError is returned if a temp file could not be created
umbynos marked this conversation as resolved. Outdated Show resolved Hide resolved
	type FileCreationFailedError struct {
Copy link Contributor @per1234 per1234 Mar 24, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. As this is an exported object, this will be a breaking change and so the standard procedure should be followed to communicate that to the users. umbynos reacted with thumbs up emoji Copy link Contributor Author @umbynos umbynos Mar 24, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I did not though about it, but you are right
	Message string
	Cause error
		}

	func (e *TempFileCreationFailedError) Error() string {
	return composeErrorMsg(tr("Cannot create temp file"), e.Cause)
	func (e *FileCreationFailedError) Error() string {
	return composeErrorMsg(e.Message, e.Cause)
		}

	func (e *TempFileCreationFailedError) Unwrap() error {
	func (e *FileCreationFailedError) Unwrap() error {
		return e.Cause
		}

		// ToRPCStatus converts the error into a *status.Status
	func (e TempFileCreationFailedError) ToRPCStatus() status.Status {
	func (e FileCreationFailedError) ToRPCStatus() status.Status {
		return status.New(codes.Unavailable, e.Error())
		}

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -469,9 +469,9 @@ func UpdateIndex(ctx context.Context, req *rpc.UpdateIndexRequest, downloadCB Do

		var tmp *paths.Path
		if tmpFile, err := ioutil.TempFile("", ""); err != nil {
	return nil, &arduino.TempFileCreationFailedError{Cause: err}
	return nil, &arduino.FileCreationFailedError{Message: tr("Cannot create temp file"), Cause: err}
		} else if err := tmpFile.Close(); err != nil {
	return nil, &arduino.TempFileCreationFailedError{Cause: err}
	return nil, &arduino.FileCreationFailedError{Message: tr("Cannot create temp file"), Cause: err}
		} else {
		tmp = paths.New(tmpFile.Name())
		}
Expand Down Expand Up		@@ -502,9 +502,9 @@ func UpdateIndex(ctx context.Context, req *rpc.UpdateIndexRequest, downloadCB Do
		URLSig.Path += ".sig"

		if t, err := ioutil.TempFile("", ""); err != nil {
	return nil, &arduino.TempFileCreationFailedError{Cause: err}
	return nil, &arduino.FileCreationFailedError{Message: tr("Cannot create temp file"), Cause: err}
		} else if err := t.Close(); err != nil {
	return nil, &arduino.TempFileCreationFailedError{Cause: err}
	return nil, &arduino.FileCreationFailedError{Message: tr("Cannot create temp file"), Cause: err}
		} else {
		tmpSig = paths.New(t.Name())
		}
Expand Down