Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix core list --all sometimes crashing #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umbynos merged 6 commits into master from umbynos/fix-core-list-all
Oct 25, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test to check if the bug is fixed
  • Loading branch information
umbynos committed Oct 25, 2021
commit 08bfa837f64ef2ebf0a7e3fb240c2147b70a486c
10 changes: 10 additions & 0 deletions test/test_core.py
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,3 +812,13 @@ def test_core_loading_package_manager(run_command):

result = run_command(["core", "list", "--all", "--format", "json"])
assert result.ok # this should not make the cli crash


def test_core_index_without_checksum(run_command):
assert run_command(["config", "init", "--dest-dir", "."])
url = "https://raw.githubusercontent.com/keyboardio/ArduinoCore-GD32-Keyboardio/main/package_gd32_index.json" # noqa: E501
assert run_command(["config", "add", "board_manager.additional_urls", url])

assert run_command(["core", "update-index"])
result = run_command(["core", "list", "--all"])
assert result.ok # this should not make the cli crash

AltStyle によって変換されたページ (->オリジナル) /