-
-
Notifications
You must be signed in to change notification settings - Fork 422
Fix library verification when installing from git repo or zip file #1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@silvanocerza
silvanocerza
added
type: imperfection
Perceived defect in any part of project
topic: CLI
Related to the command line interface
topic: gRPC
Related to the gRPC interface
labels
Sep 23, 2021
@silvanocerza
silvanocerza
force-pushed
the
scerza/fix-library-verification
branch
from
September 23, 2021 15:12
0aa88da to
5e37966
Compare
per1234
per1234
requested changes
Sep 23, 2021
@silvanocerza
silvanocerza
force-pushed
the
scerza/fix-library-verification
branch
from
September 23, 2021 15:45
5e37966 to
0407bb3
Compare
@silvanocerza
silvanocerza
force-pushed
the
scerza/fix-library-verification
branch
from
September 23, 2021 15:52
0407bb3 to
73472c0
Compare
per1234
per1234
requested changes
Sep 23, 2021
Co-authored-by: per1234 <accounts@perglass.com>
per1234
per1234
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Silvano!
@silvanocerza
silvanocerza
deleted the
scerza/fix-library-verification
branch
September 24, 2021 08:41
silvanocerza
added a commit
that referenced
this pull request
Sep 24, 2021
...1466) * Fix library verification when installing from git repo or zip file * Enhance code comments and unit tests Co-authored-by: per1234 <accounts@perglass.com> Co-authored-by: per1234 <accounts@perglass.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Solves a bug.
When installing a library from a git repository or from a zip file the verification step strictly requires the library to contain an header file with the same name as the repository URL or as the root directory contained in the zip file.
This verification is too strict and doesn't respect the official library specifications, so often valid libraries are rejected.
The verification step is now less strict and reflect the library specification closely.
titled accordingly?
Nope.
Fix #1306.
See how to contribute