-
-
Notifications
You must be signed in to change notification settings - Fork 422
Fix an issue with arduino-cli lib install stripping too many characters from library names in git URLs #1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrimRight greedily removes as any matching characters from the cutset as possible which can inadvertently remove characters from the library name.
CLA assistant check
All committers have signed the CLA.
Thanks @easyas314159!
For the sake of linking things together, I'll add a note that this bug was reported by @FStefanni in the issue number #1459
@per1234
per1234
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Sep 23, 2021
silvanocerza
silvanocerza
approved these changes
Sep 23, 2021
Thanks for the fix @easyas314159! Really appreciate it. 🙏
This was referenced Sep 23, 2021
Closed
silvanocerza
pushed a commit
that referenced
this pull request
Sep 24, 2021
TrimRight greedily removes as any matching characters from the cutset as possible which can inadvertently remove characters from the library name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fixes an issue with handling of git URLs when installing libraries using
--git-url.When using
arduino-cli lib installwith the--git-urlflag too many characters may be stripped from the end of the library name. Internally the librarymanagersparseGitURLfunction is incorrectly usingstrings.TrimRightinstead ofstrings.TrimSuffix.Example:
parseGitURLnow correctly strips the.gitsuffix from git URLs.titled accordingly?
This PR contains no breaking changes
There are not currently any test cases for
arduino/libraries/librariesmanager/install.go, given the size of the change, and how much time I currently have available I'm not sure if unit tests for this are strictly necessary.See how to contribute