Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add completion for PowerShell #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silvanocerza merged 7 commits into arduino:master from manchoz:mnx_powershell_completion
Aug 26, 2021

Conversation

Copy link
Contributor

@manchoz manchoz commented Aug 25, 2021

Add support to generate PowerShell completions for arduino-cli in PowerShell 5.0+

This PR:

  • Add PowerShell to completion code generation

While waiting for documentation, please, you can test it following the instructions at Autocomplete in PowerShell.

akash73 reacted with thumbs up emoji silvanocerza and umbynos reacted with heart emoji
@manchoz manchoz marked this pull request as draft August 25, 2021 11:27
@manchoz manchoz marked this pull request as ready for review August 25, 2021 14:43
Copy link
Contributor Author

manchoz commented Aug 25, 2021

Add tests and documentation.

@umbynos @per1234 please, review.

Let me know if I need to squash the commits.

@manchoz manchoz changed the title (削除) [WIP] Add completion for PowerShell (削除ここまで) (追記) Add completion for PowerShell (追記ここまで) Aug 25, 2021
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and it works great, I think there's only need for that small docs edit and then it's good to go for me.

Copy link
Contributor

Let me know if I need to squash the commits.

No worries, it will be squashed when merged.

Co-authored-by: Silvano Cerza <3314350+silvanocerza@users.noreply.github.com>
@silvanocerza silvanocerza merged commit 804b8d0 into arduino:master Aug 26, 2021
@manchoz manchoz deleted the mnx_powershell_completion branch August 26, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@silvanocerza silvanocerza silvanocerza approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /