-
-
Notifications
You must be signed in to change notification settings - Fork 423
[skip changelog] Update JSON output key name in integration test helper #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key names used in Arduino CLI's JSON output were made consistent and standardized. One of the helper functions for the integration tests was not updated accordingly. This was missed because it is only used when running the tests locally due to requiring a board to be connected to the computer.
silvanocerza
silvanocerza
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! It shows we don't run those tests enough. 😅
@rsora
rsora
added
type: imperfection
Perceived defect in any part of project
topic: testing
labels
Sep 22, 2021
@per1234
per1234
added
topic: infrastructure
Related to project infrastructure
and removed
topic: testing
labels
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)bug fix
The key names used in Arduino CLI's JSON output were made consistent and standardized (#1223). One of the helper functions for
the integration tests was not updated accordingly. This was missed because it is only used when running the tests locally
due to requiring a board to be connected to the computer. That caused the test to have a spurious failure:
The key name is updated to match the new JSON output format and the test is once more returning valid results.
titled accordingly?
No break.