-
-
Notifications
You must be signed in to change notification settings - Fork 423
Implement function to verify index signature with custom key #1304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
cmaglie
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nitpick.
For the rest looks good 👍🏼
@umbynos
umbynos
changed the title
(削除) Add board signature key (削除ここまで)
(追記) Add Jun 1, 2021
module_firmware_index signature key and implement function to verify signature with custom key (追記ここまで)
@umbynos
umbynos
changed the title
(削除) Add
(追記) Implement function to verify index signature with custom key (追記ここまで)
Jun 3, 2021
module_firmware_index signature key and implement function to verify signature with custom key (削除ここまで)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)feature
There is no way of specifying another gpg public key to verify if the signature of an index is correct.
module_firmware_index.jsonVerifyDetachedSignaturefunction that allows to specify the path of another gpg public keytitled accordingly?
nope
See how to contribute