-
-
Notifications
You must be signed in to change notification settings - Fork 422
[skip changelog] Update UPGRADING.md with new breaking changes #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@silvanocerza
silvanocerza
added
the
topic: documentation
Related to documentation for the project
label
Dec 7, 2020
per1234
per1234
requested changes
Dec 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor rewording suggestions.
Thanks @per1234, committed your suggestions. 👍
Co-authored-by: per1234 <accounts@perglass.com>
@silvanocerza
silvanocerza
force-pushed
the
scerza/upgrading-breaking-changes
branch
from
December 7, 2020 10:40
102726d to
a197f29
Compare
per1234
per1234
approved these changes
Dec 7, 2020
@silvanocerza
silvanocerza
deleted the
scerza/upgrading-breaking-changes
branch
December 7, 2020 11:17
silvanocerza
added a commit
that referenced
this pull request
Dec 7, 2020
* [skip changelog] Update UPGRADING.md with new breaking changes * [skip changelog] Apply suggestions from code review Co-authored-by: per1234 <accounts@perglass.com> Co-authored-by: per1234 <accounts@perglass.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Docs update.
Not applicable.
Updated the
docs/UPGRADING.mdfile with instructions on how to handle certain breaking changes.No.
None.
See how to contribute