-
-
Notifications
You must be signed in to change notification settings - Fork 422
Fix update indexes running when not necessary #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@silvanocerza
silvanocerza
changed the title
(削除) Scerza/fix compile update index (削除ここまで)
(追記) Fix update indexes running when not necessary (追記ここまで)
Nov 11, 2020
@silvanocerza
silvanocerza
force-pushed
the
scerza/fix-compile-update-index
branch
2 times, most recently
from
November 12, 2020 11:19
e92a83b to
2828f1a
Compare
Updated the PR with a different behaviour, now we make the CLI fail if local indexes related to a certain URL are not found, in these cases the user should try to update the indexes.
We also enhanced the error messages when updating indexes with update and core update-index if any URL is not reachable.
@silvanocerza
silvanocerza
force-pushed
the
scerza/fix-compile-update-index
branch
from
November 12, 2020 11:41
2828f1a to
e22a9df
Compare
@silvanocerza
silvanocerza
deleted the
scerza/fix-compile-update-index
branch
November 16, 2020 10:21
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
An overall enhancement of the CLI behaviour.
If a local index file is missing the CLI tries to download it from the related additional URL whenever it tries to create a new internal instance, if that URL is unreachable for any reason the subsequent command always fails.
This would happen when executing any command.
Indexes update is now only executed for certain specific commands like
update,core update-index,lib update-indexandcore search, or whenever thelibrary_index.jsonorpackage_index.jsonfiles are missing.The initialization of an internal CLI instance still makes the whole command fail if a local index file is missing but the message is clearer now.
Updating indexes now shows a clear error if an URL is unreachable for any reason, we check for
4xxor5xxHTTP status codes so in those cases it fails.No.
None.
This should also fix #1050.
See how to contribute