Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Core and lib search command now update indexes first #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silvanocerza merged 1 commit into master from scerza/auto-index-update
Oct 27, 2020

Conversation

Copy link
Contributor

@silvanocerza silvanocerza commented Oct 21, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
    Enhances existing commands.
  • What is the current behavior?
    Calling core search or lib search doesn't update indexes before searching.
  • What is the new behavior?
    Calling core search or lib search now updates indexes before searching.
  • Does this PR introduce a breaking change?
    No.

See how to contribute

endorama reacted with heart emoji
Copy link
Contributor

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just performed a test searching for ArduinoIoTCloud (latest is 0.11.2, my "local" latest is 0.11.1) and it worked like a charm!
🤟

silvanocerza reacted with rocket emoji
Copy link

@endorama are you happy we put it in the sprint? 😀

Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully tested
no objections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

@cmaglie cmaglie Awaiting requested review from cmaglie

+1 more reviewer

@endorama endorama endorama approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inform user when the indexes are outdated

AltStyle によって変換されたページ (->オリジナル) /