Skip to content

Use debug "configurations" instead or "recipes" #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

cmaglie merged 11 commits into arduino:master from cmaglie:debug_metadata

Nov 3, 2020

Merged

Use debug "configurations" instead or "recipes" #1033

Changes from 1 commit

Commits

Show all changes

Select commit Hold shift + click to select a range

Added 'debug --info/-I' flag to get debug metadata

cmaglie Oct 14, 2020

Debugger: do not use anymore pre-made recipes

cmaglie Oct 15, 2020

Added nicer color ouput for 'debug --info'

cmaglie Oct 15, 2020

Removed deprecated field

cmaglie Oct 15, 2020

Merged together DebugConfigReq protoc type

cmaglie Oct 15, 2020

Debug: added programmer selection flag

cmaglie Oct 16, 2020

debug: return error if debugging is not supported by the platform

cmaglie Oct 19, 2020

debug: openocd server now require full path to openocd executable

cmaglie Oct 19, 2020

debug: fixed test runner

cmaglie Oct 19, 2020

debugger: Fixed command line tests

cmaglie Oct 19, 2020

debugger: hotfix for samd platforms 1.8.8 and 1.8.9

cmaglie Oct 28, 2020

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

Removed deprecated field

Loading branch information

cmaglie committed Oct 28, 2020

commit 3fa8d4cf23a47811e6f4d42ae6bd26b51dd1ae70

4 changes: 0 additions & 4 deletions commands/debug/debug.go

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -109,10 +109,6 @@ func Debug(ctx context.Context, req *dbg.DebugConfigReq, inStream io.Reader, out

		// getCommandLine compose a debug command represented by a core recipe
		func getCommandLine(req dbg.DebugConfigReq, pm packagemanager.PackageManager) ([]string, error) {
	if req.GetImportFile() != "" {
	return nil, errors.New("the ImportFile parameter has been deprecated, use ImportDir instead")
	}

		debugInfo, err := GetDebugInfo(context.Background(), &dbg.GetDebugInfoReq{
		Instance: req.GetInstance(),
		Fqbn: req.GetFqbn(),
Expand Down

156 changes: 71 additions & 85 deletions rpc/debug/debug.pb.go

Show comments View file Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions rpc/debug/debug.proto

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -64,8 +64,6 @@ message DebugConfigReq {
		string port = 4;
		// Which GDB command interpreter to use.
		string interpreter = 5;
	// DEPRECATED: use import_dir instead
	string import_file = 7 [deprecated = true];
		// Directory containing the compiled executable. If `import_dir` is not
		// specified, the executable is assumed to be in
		// `{sketch_path}/build/{fqbn}/`.
Expand Down