Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(board): return adb stdout/err in case of error #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucarin91 merged 2 commits into main from board-adb-add-error-out
Nov 3, 2025

Conversation

@lucarin91
Copy link
Contributor

@lucarin91 lucarin91 commented Oct 31, 2025
edited
Loading

Motivation

We should always include the command stdout/stderr in case the process fails.

Change description

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

per1234 reacted with thumbs up emoji
@lucarin91 lucarin91 requested a review from a team October 31, 2025 11:20
@per1234 per1234 added the bug Something isn't working label Oct 31, 2025
@lucarin91 lucarin91 merged commit a2f7219 into main Nov 3, 2025
6 checks passed
@lucarin91 lucarin91 deleted the board-adb-add-error-out branch November 3, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xayton Xayton Xayton approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /