-
Notifications
You must be signed in to change notification settings - Fork 7
(fix) Delete App by path #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lucarin91
lucarin91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should verify that we don't reintroduce the issue solved here #112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we by default we should return an error if the app is running or if it has some data, and maybe have a parameter to force this behaviour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering whether it would be useful to add a parameter to make the command more customizable.
Then I thought: "But in this case, we would need to modify both the CLI and the API."
Looking at the code, I just realized that we don't have a CLI command for app deletion!
I am going to open an issue for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already done here #170
Uh oh!
There was an error while loading. Please reload this page.
Motivation
DeleteApp method should stop and destroy each application selected for deletion by the user.
As of now just starting or restarting app are running or starting. So all the application that are in other status will be deleted (removed) but the resource will be not destroyed. This will create an inconsistent state for the app that will be created with the same name (app path)