Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: do not return hidden variables #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dido18 merged 5 commits into main from hidden-variable
Dec 5, 2025
Merged

feat: do not return hidden variables #143

dido18 merged 5 commits into main from hidden-variable
Dec 5, 2025

Conversation

@dido18
Copy link
Contributor

@dido18 dido18 commented Dec 4, 2025
edited
Loading

Motivation

Some brick variables must not be shown via the AppLab since they are "internal" variables of the bricks.

An example of such variables is CUSTOM_MODEL_PATH.

Change description

Support the hidden boolean variable added in the brick index to hide variables.

  • do not return the variables in the GET /v1/bricks/{id} and GET /v1/apps/{id}/bricks/{id} with hidden:true
  • A hidden variable could be added "manually" to the app.yaml

Additional Notes

Related pr - arduino/app-bricks-py#38

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@dido18 dido18 linked an issue Dec 4, 2025 that may be closed by this pull request
3 tasks
@dido18 dido18 marked this pull request as ready for review December 4, 2025 15:39
@dido18 dido18 requested a review from a team December 4, 2025 15:39
@dido18 dido18 changed the title (削除) add hidden variable (削除ここまで) (追記) feat: do not return hidden variables (追記ここまで) Dec 4, 2025
@dido18 dido18 merged commit 70b5caa into main Dec 5, 2025
6 checks passed
@dido18 dido18 deleted the hidden-variable branch December 5, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucarin91 lucarin91 lucarin91 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API: Hide model configuration variables

2 participants

AltStyle によって変換されたページ (->オリジナル) /