-
Notifications
You must be signed in to change notification settings - Fork 7
bug: fix required_devices handling #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
required devices was loading after checking if bricks requires a container.
So, required devices are not loaded in case of bricks without a container
@Xayton
Xayton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the new examples (not merged yet).
Works as expected: you get a no speaker device found message.
Motivation
required_devicessection must be checked also in case there are no linked containers.Change description
Move detection logic before code loop exiting
Reviewer checklist
main.