-
Notifications
You must be signed in to change notification settings - Fork 7
[CLI] Add a destroy app command #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mirkoCrobu
commented
Dec 9, 2025
Add uninitialized status and set status information for app list
image
@lucarin91
lucarin91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add an endpoint for doing this (maybe in a subsequent PR)
internal/orchestrator/helpers.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the TODO or add a FIXME, because I would like to remove this function and just use the getAppStatusByPath instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the TODO because I implemented it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you don't, after your change we have two functions that do the same thing, the objective was to have just a single one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah now I see what you mean, done by the following:
mirkoCrobu
commented
Dec 16, 2025
We should also add an endpoint for doing this (maybe in a subsequent PR)
Motivation
closes #105
We could add a new app destroycommand (or a similar name) for stopping and removing all the data of an app.
In particular, we should do a docker-compose down and remove the .cache.
We should also consider adding a destroyed (or a better name) that is the default state of an app if it has not been run yet.
With this additional state, we would then be able to always return a state when listing the apps (right now apps and examples that have not been run, will show up as with no state).
Change description
Additional Notes
Reviewer checklist
main.