-
Notifications
You must be signed in to change notification settings - Fork 7
make example code optional for brick example details #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dido18
dido18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add unit tests where possible to avoid regression
@lucarin91
lucarin91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but do you think we are able to add a test for this. AFAIK, we already have some testdata, maybe it isn't too complicated to do it.
@dido18
dido18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have Test 🦸
I suggest simplifying the code of the example, (e.g remoe png and other stuff not needed) and keep only the files that we need to test
.licensed.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this space
mirkoCrobu
commented
Oct 24, 2025
Replaced by : #19
Uh oh!
There was an error while loading. Please reload this page.
Motivation
closes #795
Change description
Some bricks don't have any code example folder.
In this case, we should return null for the field "code_examples" when calling /v1/bricks/{brick_id}
Additional Notes
Reviewer checklist
main.