-
-
Notifications
You must be signed in to change notification settings - Fork 731
Add a weak attribute to serial IRQ allowing real time communication lib. #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This seems like a reasonable approach, but I think we can do better. For AVR, we already set things up so that if Serial is not references, the entire object and ISR is omitted. See #489 for brief discussion and links about this approach.
Thank you for pointing me into this direction.
Indeed it seems to be a better solution, but a more time consuming one to make.
Like you I would love to make it happen but I don't have a lot of time.
Anyway I will make a post-it on my blackboard about it...
CLAassistant
commented
Apr 9, 2021
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@nicolas-rabault hi, any news? I would also like to use my own serial IRQs
There is no way to have a complexe software communication protocol without IRQ.
Arduino should comply with it allowing real time constraints protocols.
The best way could be to be able to avoid Serial object creation and call a custom object into IRQ, but I can't find any way to do it without breaking everything.
Another good way could be to make something like an attach_interrupt function on Serial object. But it's not really standard into Arduino ecosystem and impact everyone with a little bit more CPU time on each byte reception for the benefits of some specific guys like me.
The last way is to declare IRQ as weak allowing someone to take the lead on IRQ. In this case, there is a dead Serial object but this modification doesn't do anything in any other case and the custom serial lib developper is the guilty one.