-
-
Notifications
You must be signed in to change notification settings - Fork 730
Added printf to Print class to have Serial.printf() functionality #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution. However, I'm closing this, since:
- Changes to Print.h should be made through the arch-independent https://github.com/arduino/ArduinoCore-API repo in the future
- There is already a similar PR there: Add printf to print class ArduinoCore-API#28
- So far, the Arduino team has specifically decided against including printf, see Print.h add printf API ArduinoCore-API#32 and Add printf to print class ArduinoCore-API#28 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adafruits version of the SAMD Arduino framework has Print::printf function. As the SAMD MCUs are not as memory limited than the AVR 8 bit MCUs I think it will not hurt to add it.