-
-
Notifications
You must be signed in to change notification settings - Fork 92
WiFiS3 and WiFIC3 Add wl definitions #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pennam
pennam
changed the title
(削除) Add wl definitions (削除ここまで)
(追記) WiFiS3 and WiFIC3 Add wl definitions (追記ここまで)
Feb 13, 2025
maidnl
maidnl
requested changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 wrong comments to be reviewed
@per1234
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Feb 14, 2025
Co-authored-by: Daniele <34984733+maidnl@users.noreply.github.com>
Co-authored-by: Daniele <34984733+maidnl@users.noreply.github.com>
@pennam
pennam
force-pushed
the
add-wl-definitions
branch
from
February 19, 2025 16:49
c1117fa to
b5bb105
Compare
@maidnl fixed!
maidnl
maidnl
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #294
I've added only WL*_LENGTH definitions because even though they are mostly unused they are handy to declare arrays as explained in the issue.