-
-
Notifications
You must be signed in to change notification settings - Fork 92
Ethernet - complete API (setHostname, dnsIP(n), hostByName, ...) #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@per1234
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Dec 21, 2023
Thanks @JAndrassy! I'm just commenting to explain that the failure of the "Compile Examples" workflow run is caused by a bug in Arduino CLI; not by any problem introduced by this PR. So don't worry about that failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
For legacy Ethernet API,
setDnsServerIPwas missing.Many Ethernet libraries have now the getters and setters as the WiFi API:
setDNS,dnsIP(n),macAddresshostByNameis useful to split blockingclient.connect(gost, port)into to steps or debug DNS.setDNS(dns1, dns2)is in the PR #200that PR is important for
dnsServerIPanddnsIP(n)too.tested with LegacyEthernetTest
overview of API in librarries