Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

I2C hot switch master <-> slave #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maidnl wants to merge 5 commits into arduino:main from maidnl:i2c_switching_roles_dev

Conversation

Copy link
Contributor

@maidnl maidnl commented Nov 10, 2023

Solve: #180
This PR introduces the possibility to change back and forth the role on the I2C from Master to Slave and vice versa.

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I believe err can be dropped. Let's do that and than this PR can be merged 👍

Copy link
Member

Before merging I'd try a cleanup to get the minimum amount of changes in IRQManager (I know it might be hard but it could avoid cross references difficult to spot and fix afterwards)
aentinger reacted with thumbs up emoji

Copy link
Contributor Author

maidnl commented Nov 15, 2023

This PR is not longer needed because this new PR #191 supersedes this one

@per1234 per1234 added type: imperfection Perceived defect in any part of project conclusion: duplicate Has already been submitted labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm Awaiting requested review from facchinm

1 more reviewer

@aentinger aentinger aentinger requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UNO R4 access to DS1307 only works if board is used as a master exclusively

AltStyle によって変換されたページ (->オリジナル) /