-
-
Notifications
You must be signed in to change notification settings - Fork 214
Reduce the number of WiFi join retry to avoid watchdog reset #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pennam
pennam
force-pushed
the
reduce-wifi-join-retry
branch
from
September 26, 2024 09:26
5646e9b to
fbd6c4c
Compare
I tested this PR against a cloud sketch that tries to connect to a wifi network that doesn't exist. First I run everything without this patch, then I recompiled the mbed core for each of the board listed below. I considered the test a success when the board didn't get restarted by the watchdog.
- Portenta H7 ✔️
- OPTA ✔️
- GIGA ✔️
- NICLA ✔️
andreagilardoni
andreagilardoni
approved these changes
Oct 3, 2024
Note to self: remember to update patch number before merge 🙂
@pennam
pennam
force-pushed
the
reduce-wifi-join-retry
branch
from
October 21, 2024 08:27
fbd6c4c to
c2cfecf
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Maximum watchdog window is 32s, join worst case 7 * 5 = 35s
This PR reduces the max number of retries to 1 to block at most 7 seconds