-
-
Notifications
You must be signed in to change notification settings - Fork 214
Refactor and fix RPC library. #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@iabdalkader
iabdalkader
force-pushed
the
refactor_rpc_library
branch
4 times, most recently
from
December 29, 2023 10:27
7c7d1ad
to
b7bb1ab
Compare
@iabdalkader
iabdalkader
force-pushed
the
refactor_rpc_library
branch
2 times, most recently
from
January 10, 2024 12:12
bbd094b
to
6f79f00
Compare
- Fix the memory corruption caused by the wrong MPU region configuration, which enabled caching of the shared memory region, without any cache maintenance in libmetal. - Fix the MPU region's TEX level, which was setting the shared memory region as a device and/or strongly-ordered memory, which caused usage faults on unaligned accesses. - Fix a deadlock that occurs if the main thread (sketch) makes a remote call and holds the virtqueue's mutex, and then gets preempted by the event thread, which in turn tries to acquire the same mutex. Note that libmetal's mutex implementation doesn't yield the CPU, it can be changed to do so, but for now the queues are protected with an OS mutex. - Fix RPCLIB msgpack unpacker memory overflow if RPMSG endpoint buffer > 512. - Optimize RPCLIB msgpack unpacker usage by allocating once and extending on demand. - Remove extra request/response threads, locking and callbacks, that were causing all sorts of concurrency issues, and were detrimental to performance. - Remove the redundant copy of messages to ring buffer, to boost the performance. - Remove many smaller dynamic allocation to improve the performance. - Use a single endpoint for message packs requests/responses ("RPC"), and another one dedicated for raw (non-packed) data. - General refactoring and cleanups, removal of dead code and variables, debugging code, etc... Signed-off-by: iabdalkader <i.abdalkader@gmail.com>
- Fix serial pass-through example. - Add MD5 checksum example. - Add RAW-channel ping-pong example. Signed-off-by: iabdalkader <i.abdalkader@gmail.com>
@iabdalkader
iabdalkader
force-pushed
the
refactor_rpc_library
branch
from
January 11, 2024 10:40
6f79f00
to
fb48b0e
Compare
Manually merged in main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Main changes in this PR:
This PR depends on the following: