-
-
Notifications
You must be signed in to change notification settings - Fork 214
Make WiFiClientSSL class available #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WiFiSSLClient was missing in the WiFi.h file, so examples using SSL fails to compile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@karlsoderby Where is the example sketch that you're referring to?
The issue with this commit is that it brings in ~200KB for every sketch that doesn't want to use SSL.
@sebromero it is targeting boards with 2MB of flash it may or may not be a problem, but the choice at that time was to leave it out.
Maybe adding an example would work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take into account the flash occupation increase
@karlsoderby Can you please point me to the examples that were not compiling?
Hi,
Can't we just include WiFiSSLClient.h header in the SSL/TLS examples?
WiFiSSLClientwas missing inWiFi.h, so examples using SSL fails to compile.The SSL example was tested with the GIGA R1 WiFi board successfully.