-
-
Notifications
You must be signed in to change notification settings - Fork 213
Enable 320x320 resolution for himax HM01B0 #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did that the same way OpenMV did: github.com/openmv/openmv/blob/master/src/omv/sensors/hm01b0.c Added constants consistently with QVGA and QQVGA modes. Updated himax.cpp, camera.cpp accordingly. My first commit to an open source project <3
CLA assistant check
All committers have signed the CLA.
|
Memory usage change @ 535beca
Click for full report table
Click for full report CSV |
Hi @idohalamit , thanks for your submission! I'm reviewing the code and there are a bunch of small things that need fixing but overall it's good! I'm commenting the needed changes inline, let me know if they sound ok to you 😉
facchinm
facchinm
requested changes
Jul 26, 2021
Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>
|
Memory usage change @ bee56dc
Click for full report table
Click for full report CSV |
Changed: - as suggested by facchinm, CAMERA_RMAX --> CAMERA_R320x320 (when relevant) - himax_max_res[] --> himax_full_res[] - in macros, "_MAX" --> "_FULL"
|
Memory usage change @ 71f2bd0
Click for full report table
Click for full report CSV |
Should I commit anything more?
@idohalamit I think we're good. @facchinm If you agree I suggest we merge 🚢
sebromero
sebromero
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@idohalamit Do you possibly have any sketch to test this?
I do!
I had some trouble with the serial connection in the demo, I did some workaround.
They should work even though I can't test them right now.
Also, you'd probably want to change the hard-coded serial port.
LiveFeed320x320.ino.txt
CameraViewer320x320.pde.txt
Merged, thanks a lot for your contribution 🙂 !
@idohalamit Thanks. Yes, the example sketch for this has some issues on Windows. I haven't gotten around to investigate as I don't have a Windows installation. Do you have an idea what exactly gets messed up in regards to the serial connection?
I haven't isolated the problem, but sending the data in small chunks (I used 512 bytes), using Serial.flush() and adding delays between sends fixes it.
sebromero
added a commit
to sebromero/ArduinoCore-mbed
that referenced
this pull request
Feb 2, 2022
* Enable 320x320 resolution for himax HM01B0 My first commit to an open source project <3 Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did that the same way OpenMV did:
github.com/openmv/openmv/blob/master/src/omv/sensors/hm01b0.c
Added constants consistently with QVGA and QQVGA modes.
Updated himax.cpp, camera.cpp accordingly.
My first commit to an open source project <3