-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix digitalRead for controllers with big flash #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA assistant check
All committers have signed the CLA.
Memory usage change @ 29a3fd8
Click for full report table
Click for full report CSV
|
@Dovgalyuk
Dovgalyuk
force-pushed
the
master
branch
from
November 18, 2022 05:31
29a3fd8
to
35edd08
Compare
Memory usage change @ 35edd08
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avr-gcc uses 16-bit type for the pointers. Therefore for when PGM data moves above 64k, it can't be read with pgm_read_word(name).
It can be fixed by retrieving full data address with pgm_get_far_address.
This patch fixes digital pin-related macros, that failed to work on AVR Mega with firmware larger than 64k.