Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix spell check false positive by ignoring word #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aentinger merged 1 commit into arduino:master from per1234:fix-spell-check
Sep 5, 2022
Merged

Fix spell check false positive by ignoring word #497

aentinger merged 1 commit into arduino:master from per1234:fix-spell-check
Sep 5, 2022

Conversation

Copy link
Contributor

@per1234 per1234 commented Sep 3, 2022

In the latest release of the codespell tool used for automated spell checking of the files of this project, the word "clen" was added to the codespell misspelled words dictionary as a misspelling of "clean" or "clan".

This caused a false detection of a struct member name clen as a misspelling, resulting in a failing spell check result:

https://github.com/arduino/ArduinoCore-avr/runs/7968491292?check_suite_focus=true#step:4:17

Error: ./cores/arduino/USBCore.h:158: clen ==> clean, clan
Codespell found one or more problems

Since the occurrence of this name is correct and intended in this project, the false positive is resolved by configuring codespell to ignore the problematic word.

In the latest release of the codespell tool used for automated spell checking of the files of this project, the word "clen" was added to the codespell misspelled words dictionary as a misspelling of "clean".
This caused a false detection of a struct member name `clen` as a misspelling, resulting in a failing spell check result. Since the occurrence of this name is correct and intended in this project, the false positive is resolved by configuring codespell to ignore the problematic word.
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clenis definitely correct, thanks for fixing the CI run 👍

@aentinger aentinger merged commit 2ff00ae into arduino:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aentinger aentinger aentinger approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /