-
-
Notifications
You must be signed in to change notification settings - Fork 140
Add documentation for CAN API to fix #221 #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jboynes
commented
Nov 2, 2023
Ugh, this failed again due to the API call to upload results. I don't have permissions to redrive this action through the UI so will upload another commit to do so. Rather than a dummy I'd apprecaite any feedback on the wording so I can incorpoarate it.
codecov-commenter
commented
Nov 3, 2023
Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (
65633ce) 95.53% compared to head (6a263a1) 95.53%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #222 +/- ## ======================================= Coverage 95.53% 95.53% ======================================= Files 16 16 Lines 1075 1075 ======================================= Hits 1027 1027 Misses 48 48
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@aentinger
aentinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Add documentation to the API methods, to clarify order of message transmission and define other behaviours.