Add String::isEmpty() #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

aentinger merged 2 commits into arduino:master from alranel:isempty

Nov 8, 2023

Merged

Add String::isEmpty() #220

aentinger merged 2 commits into arduino:master from alranel:isempty

Nov 8, 2023

Conversation

alranel

Copy link

Contributor

@alranel alranel commented Oct 31, 2023

This PR adds a tiny inline isEmpty() method to the String class. This is borrowed from the ESP32 core which made it popular.

@codecov-commenter

Copy link

codecov-commenter commented Oct 31, 2023 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65633ce) 95.53% compared to head (2e5570e) 95.53%.

Additional details and impacted files

@@ Coverage Diff @@
## master #220 +/- ##
=======================================
 Coverage 95.53% 95.53% 
=======================================
 Files 16 16 
 Lines 1075 1075 
=======================================
 Hits 1027 1027 
 Misses 48 48

Files	Coverage Δ
api/String.h	`90.00% <ø> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aentinger

aentinger suggested changes

Nov 2, 2023

View reviewed changes

Copy link

Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alranel ☕ 👋

Two minor points:

Indendation does not match the rest of the file (probably a TAB vs SPACE issue?)
Please provide a unit test that hard-codes the API expectation for this function.