-
-
Notifications
You must be signed in to change notification settings - Fork 133
Fix: add test case for CanMsgRingBuffer. #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #207 +/- ## ========================================== - Coverage 95.61% 95.52% -0.09% ========================================== Files 14 16 +2 Lines 1048 1072 +24 ========================================== + Hits 1002 1024 +22 - Misses 46 48 +2
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
d8d0b6a to
1765628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any change pertaining volatile (unless you refer to the change of unary increment/decrement operators to a binary arithmetic operation), but I do appreciate adding the test case.
Fixes a deprecated use of volatile in CanMsgRingbuffer.
Also added a basic testcase to make sure the CPP file is compiled/tested.
Relies on PR #206 to reliably run the tests under C++20