Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Arduino String/Stream add features #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PiotrekB416 wants to merge 10 commits into arduino:master
base: master
Choose a base branch
Loading
from PiotrekB416:Feat/more-string-functions

Conversation

Copy link
Contributor

@PiotrekB416 PiotrekB416 commented Sep 1, 2023
edited
Loading

Add features to Arduino::String and Arduino::Stream
[x] String.insert
[x] Stream.readln or Stream.readLine

Requested by #152
More ideas are welcome

@PiotrekB416 PiotrekB416 marked this pull request as ready for review September 2, 2023 10:17
Copy link

codecov-commenter commented Sep 2, 2023
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (65633ce) 95.53% compared to head (b9ef2e8) 95.50%.

Additional details and impacted files
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 95.53% 95.50% -0.03% 
==========================================
 Files 16 16 
 Lines 1075 1091 +16 
==========================================
+ Hits 1027 1042 +15 
- Misses 48 49 +1 
Files Coverage Δ
api/Stream.h 100.00% <ø> (ø)
api/String.cpp 97.33% <100.00%> (+0.05%) ⬆️
api/String.h 90.90% <100.00%> (+0.90%) ⬆️
api/Stream.cpp 90.00% <83.33%> (-0.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PiotrekB416 PiotrekB416 changed the title (削除) Arduino String add features (削除ここまで) (追記) Arduino String/Stream add features (追記ここまで) Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@JAndrassy JAndrassy JAndrassy left review comments

@kiiv-cz kiiv-cz kiiv-cz left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /