Fixed string::replace doesn't replace multiple occurrences of longer string with shorter one #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

aentinger merged 3 commits into arduino:master from PiotrekB416:Fix/string-replace-multiple-longer-by-shorter

Sep 4, 2023

Merged

Fixed string::replace doesn't replace multiple occurrences of longer string with shorter one #200

Changes from 1 commit

Commits

Show all changes

3 commits

Select commit Hold shift + click to select a range

f6764f4

Fix String::replace replace multiple occurrences of longer String by ...

PiotrekB416 Aug 30, 2023

f782ba4

Add tests

PiotrekB416 Aug 30, 2023

12fb6ba

Update api/String.cpp

PiotrekB416 Aug 30, 2023

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Diff view

Update api/String.cpp

Co-authored-by: per1234 <accounts@perglass.com>

Loading branch information

@PiotrekB416 @per1234

PiotrekB416 and per1234 authored Aug 30, 2023

commit 12fb6ba05e44385052a65de88f79003467bc8ce5

2 changes: 1 addition & 1 deletion api/String.cpp

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -652,7 +652,7 @@ void String::replace(const String& find, const String& replace)
		}
		} else if (diff < 0) {
		unsigned int size = len; // compute size needed for result
	diff = 0 - diff;
	diff = 0 - diff;
Copy link Contributor @aentinger aentinger Sep 4, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Ah, this line hurts 😉 . (Could it not be `abs(diff)`? However, you did not commit this crime, simply moved the line to the right position 👍 .
		while ((foundAt = strstr(readFrom, find.buffer)) != NULL) {
		readFrom = foundAt + find.len;
		size -= diff;
Expand Down

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fixed string::replace doesn't replace multiple occurrences of longer string with shorter one #200

Uh oh!

Fixed string::replace doesn't replace multiple occurrences of longer string with shorter one #200

Filter by extension

Uh oh!

Uh oh!

Diff view

Diff view

Uh oh!

There are no files selected for viewing

@aentinger aentinger Sep 4, 2023

Choose a reason for hiding this comment

Uh oh!