Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

isAscii: avoid dependency on _GNU_SOURCE #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
facchinm merged 5 commits into master from patch_isascii
Dec 21, 2022
Merged

isAscii: avoid dependency on _GNU_SOURCE #176

facchinm merged 5 commits into master from patch_isascii
Dec 21, 2022

Conversation

Copy link
Member

@facchinm facchinm commented Dec 20, 2022 •
edited
Loading

DhruvaG2000 and beriberikix reacted with rocket emoji
Copy link

codecov-commenter commented Dec 20, 2022 •
edited
Loading

Codecov Report

Base: 96.11% // Head: 96.20% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (981a9f6) compared to base (c8ee90f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 96.11% 96.20% +0.08% 
==========================================
 Files 13 13 
 Lines 953 949 -4 
==========================================
- Hits 916 913 -3 
+ Misses 37 36 -1
Impacted Files Coverage Δ
api/WCharacter.h 100.00% <100.00%> (ø)
api/Print.cpp 95.20% <0.00%> (-0.03%) ⬇️
api/Stream.cpp 91.42% <0.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

Thanks for the PR @facchinm!

I haven't test it yet, but doesn't it also need an custom implementation of toascii(), as used in toAscii()?

// Converts c to a 7-bit unsigned char value that fits into the
// ASCII character set, by clearing the high-order bits.
inline int toAscii(int c)
{
return toascii (c);
}

Copy link
Member Author

@carlosperate thanks for pointing that out, I added the patch and test for that function too
carlosperate reacted with thumbs up emoji

@facchinm facchinm merged commit 691d84d into master Dec 21, 2022
@aentinger aentinger deleted the patch_isascii branch November 28, 2023 07:46
@aentinger aentinger restored the patch_isascii branch November 28, 2023 07:46
@aentinger aentinger deleted the patch_isascii branch November 28, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /