-
-
Notifications
You must be signed in to change notification settings - Fork 133
Adding MacAddress, MacAddress8 #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MacAddress, MacAddress8 #162
Conversation
Adding New Classes MacAddress, MacAddress8 in the style of IPAddress. Note I didn't include Printable, as I don't understand how that works. If someone else wants to add it later, they are welcome to do so. This is my first time contributing to this repository, so please feel free to point out any mistakes. This library originated on arduino-esp32 (espressif/arduino-esp32#6667). It was suggested that I contribute to the Arduino core as well :)
CLA assistant check
All committers have signed the CLA.
Codecov Report
Merging #162 (a740b1c) into master (e03b653) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #162 +/- ## ======================================= Coverage 96.00% 96.00% ======================================= Files 13 13 Lines 827 827 ======================================= Hits 794 794 Misses 33 33
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update e03b653...a740b1c. Read the comment docs.
Added printTo(). Added index operators and type converters. See test project here: https://github.com/mrengineer7777/MA_Test. No further changes expected.
Final version, ready for review. See test project here: https://github.com/mrengineer7777/MA_Test
It seems there is no interest so I will be deleting this PR soon.
Sorry, this fell through the cracks. In any case adding test code would be much appreciated.
@facchinm what do you think re integrating this to the core API?
Uh oh!
There was an error while loading. Please reload this page.
Adding New Classes MacAddress, MacAddress8 in the style of IPAddress. Note I didn't include Printable, as I don't understand how that works (edit: see updates below). If someone else wants to add it later, they are welcome to do so. This is my first time contributing to this repository, so please feel free to point out any mistakes.
This library originated on arduino-esp32 (espressif/arduino-esp32#6667). It was suggested that I contribute to the Arduino core as well :)