-
-
Notifications
You must be signed in to change notification settings - Fork 133
Remove include of Hardware*.h from ArduinoAPI.h #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblanchon
commented
Mar 4, 2023
Hi guys,
I'm sorry to dig into such an old PR but why did you remove Client.h?
deprecated/Client.h says:
including Client.h is deprecated, for all future projects use Arduino.h instead
This means Client.h should be included in ArduinoAPI.h, right?
Best regards,
Benoit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardware related includes can be removed from ArduinoAPI.h since they can be included by the specific interfaces. This gives also the users more flexibility to implement their own classes.
In ArduinoCore-API integration in ArduinoCore-samd, the 3 includes removed form ArduinoAPI.h are, instead, here:
ArduinoCore-mbed must be modified as well to correctly include this files. This branch NOHardwareIncludeInAPI provides a possible implementation. The CI workflow has been locally modified to ensure that this proposed branch of ArduinoCore-API is checked out. The compilation has been successful: https://github.com/giulcioffi/ArduinoCore-mbed/actions/runs/257232488