Add in accessibility support for screen readers in board and library managers #9145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facchinm merged 1 commit into arduino:master from joew46167:master

Aug 19, 2019

Merged

Add in accessibility support for screen readers in board and library managers #9145

facchinm merged 1 commit into arduino:master from joew46167:master

Aug 19, 2019

Conversation

joew46167

Copy link

@joew46167 joew46167 commented Aug 15, 2019 •

edited

Loading

ContributedLibraryTableCellJPanel.java: Add description to accessibility context
ContributedPlatformTableCellJPanel.java: Add description to accessibility context

ProgressJProgressBar.java:
Add status to accessibility context
make progress bar focusable so screen reader can access

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

Does your submission pass tests?
Have you lint your code locally prior to submission?

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes


 Add in accessibility support for screen readers:

6bcd052

 ContributedLibraryTableCellJPanel.java: Add description to accessibility context
 ContributedPlatformTableCellJPanel.java: Add description to accessibility context
 ProgressJProgressBar.java:
 Add status to accessibility context
 make progress bar focusable so screen reader can access

@joew46167

Copy link

Author

joew46167 commented Aug 15, 2019

I clicked Have you written new tests for your core changes, as applicable? but imo it isn't applicable.

@facchinm

Copy link

Member

facchinm commented Aug 19, 2019

Hi @joew46167 ,
the PR looks fine! Did you have the chance to test it manually with a screen reader? In which platform?
I'm going to merge it immediately to get a broader audience to test it and eventually we can amend it later