-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Use contributions.trust.all and download the signature in any case #9096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmaglie
merged 5 commits into
arduino:master
from
mattiabertorello:fix-download-signature
Aug 20, 2019
Merged
Use contributions.trust.all and download the signature in any case #9096
cmaglie
merged 5 commits into
arduino:master
from
mattiabertorello:fix-download-signature
Aug 20, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
cmaglie
requested changes
Jul 24, 2019
arduino-core/src/cc/arduino/contributions/DownloadableContributionsDownloader.java
Show resolved
Hide resolved
arduino-core/src/cc/arduino/contributions/DownloadableContributionsDownloader.java
Outdated
Show resolved
Hide resolved
@mattiabertorello
mattiabertorello
force-pushed
the
fix-download-signature
branch
from
July 25, 2019 06:52
e0374c1 to
1c1051c
Compare
@cmaglie
cmaglie
force-pushed
the
fix-download-signature
branch
from
August 8, 2019 08:14
1c1051c to
9f15573
Compare
@cmaglie
cmaglie
force-pushed
the
fix-download-signature
branch
from
August 20, 2019 15:57
9f15573 to
de24c24
Compare
If the package_index.json signature is not valid, a dialog box asking the user to "update" the index is shown. Previously a java-exception was printed if running from terminal or the IDE would not start at all (with no apparent reason) if lanched from GUI.
@cmaglie
cmaglie
force-pushed
the
fix-download-signature
branch
from
August 20, 2019 16:03
de24c24 to
5bb9f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR will remove the signature check if
allow_insecure_packagesorcontributions.trust.allis true but the signature will be downloaded in any case